Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRS and ERS don't promote replicas taking backups #16997

Merged
merged 24 commits into from
Nov 21, 2024
Merged

PRS and ERS don't promote replicas taking backups #16997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
b2c0b5c
PRS and ERS don't promote replicas taking backups
ejortegau Oct 18, 2024
e9fda77
Rebuild vtadmin proto files
ejortegau Oct 18, 2024
8a196c9
Fix assignment to nil map
ejortegau Oct 18, 2024
d7b8ddd
Fix TestGRPCTMServer
ejortegau Oct 18, 2024
2d22cf4
Improve error message.
ejortegau Oct 22, 2024
54bdcc0
Address PR comments
ejortegau Oct 30, 2024
fc69610
Reorder some code to skip sorting not preferred tablets when we won't…
ejortegau Oct 30, 2024
f7bbd32
Merge branch 'main' into ejortegau/reparenting-skips-tablets-running-…
ejortegau Oct 31, 2024
67f901d
Regenerate some code from proto after fixing merge conflicts
ejortegau Oct 31, 2024
2819bf1
Add change info to changelog
ejortegau Oct 31, 2024
92a11e0
Make linter happy
ejortegau Oct 31, 2024
6db5006
Address PR comments
ejortegau Nov 4, 2024
30114e5
Improve testing for skipping promoting host running backup
ejortegau Nov 4, 2024
ca7078e
Fix imports some more
ejortegau Nov 4, 2024
6840803
Address PR comments
ejortegau Nov 5, 2024
8b41ff1
Fix vtadmin proto stuff
ejortegau Nov 5, 2024
a29efa7
Fix more proto stuff
ejortegau Nov 5, 2024
09331a9
Fix missing fields coming from renaming of proto fields +
ejortegau Nov 5, 2024
e315d12
More field renaming for betetr consistency
ejortegau Nov 5, 2024
3405351
Address PR comment
ejortegau Nov 5, 2024
86f0182
Merge branch 'main' into ejortegau/reparenting-skips-tablets-running-…
ejortegau Nov 8, 2024
61ad1b6
Address PR comments
ejortegau Nov 8, 2024
83f7b62
Run go run ./go/tools/releases/releases.go to make CI check happy
ejortegau Nov 8, 2024
97c0271
Address PR comment
ejortegau Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/22.0/22.0.0/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Changelog of Vitess v22.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this file will be generated when we do the first release candidate for v22. No need to create it right now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was autogenerated when I ran a command indicated in a failing CI check.


### Enhancement
#### Cluster management
* Prefer not promoting replicas that are taking backups [#16997](https://github.com/vitessio/vitess/pull/16997)
13 changes: 13 additions & 0 deletions changelog/22.0/22.0.0/summary.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- **[Major Changes](#major-changes)**
- **[RPC Changes](#rpc-changes)**
- **[Prefer not promoting a replica that is currently taking a backup](#reparents-prefer-not-backing-up)**


## <a id="major-changes"/>Major Changes</a>
Expand All @@ -13,3 +14,15 @@
These are the RPC changes made in this release -

1. `GetTransactionInfo` RPC has been added to both `VtctldServer`, and `TabletManagerClient` interface. These RPCs are used to fecilitate the users in reading the state of an unresolved distributed transaction. This can be useful in debugging what went wrong and how to fix the problem.

### <a id="reparents-prefer-not-backing-up"/>Prefer not promoting a replica that is currently taking a backup

Emergency reparents now prefer not promoting replicas that are currently taking backups with a backup engine other than
`builtin`. Note that if there's only one suitable replica to promote, and it is taking a backup, it will still be
promoted.

For planned reparents, hosts taking backups with a backup engine other than `builtin` are filtered out of the list of
valid candidates. This means they will never get promoted - not even if there's no other candidates.

Note that behavior for `builtin` backups remains unchanged: a replica that is currently taking a `builtin` backup will
never be promoted, neither by planned nor by emergency reparents.
1 change: 1 addition & 0 deletions changelog/22.0/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
## v22.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is also not required. It will eventually be generated during release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, autogenerated after running a command indicated in a failing CI check, IIRC.

* **[22.0.0](22.0.0)**
* [Changelog](22.0.0/changelog.md)
225 changes: 123 additions & 102 deletions go/vt/proto/replicationdata/replicationdata.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

70 changes: 70 additions & 0 deletions go/vt/proto/replicationdata/replicationdata_vtproto.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading