Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing changelog for PR #16852 #17002

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Add missing changelog for PR #16852 #17002

merged 3 commits into from
Oct 18, 2024

Conversation

timvaillancourt
Copy link
Contributor

Description

This PR adds a missing v21 changelog for #16852

cc @rohit-nayak-ps

Related Issue(s)

#16852

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@timvaillancourt timvaillancourt added Type: Documentation Component: Documentation docs related issues/PRs Backport to: release-21.0 Needs to be backport to release-21.0 labels Oct 18, 2024
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 18, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 18, 2024
@github-actions github-actions bot added this to the v22.0.0 milestone Oct 18, 2024
@timvaillancourt
fix markdown
a51331f 
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt
fix markdown again
264c6e1 
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt timvaillancourt removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Oct 18, 2024
@frouioui frouioui merged commit 830ab74 into vitessio:main Oct 18, 2024
100 checks passed
vitess-bot pushed a commit that referenced this pull request Oct 18, 2024
@vitess-bot @vitess-bot
Add missing changelog for PR #16852 (#17002)
80f2d9b 
Signed-off-by: Tim Vaillancourt <[email protected]>
@vitess-bot vitess-bot bot mentioned this pull request Oct 18, 2024
Merged
@timvaillancourt timvaillancourt deleted the pr16852-changelog branch October 18, 2024 14:44
rohit-nayak-ps pushed a commit that referenced this pull request Oct 18, 2024
@vitess-bot
[release-21.0] Add missing changelog for PR #16852 (#17002) (#17006)
89f3707 
Signed-off-by: Tim Vaillancourt <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@arthurschreiber arthurschreiber arthurschreiber approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps

Assignees
No one assigned
Labels
Backport to: release-21.0 Needs to be backport to release-21.0 Component: Documentation docs related issues/PRs Type: Documentation
Projects
None yet
Milestone
v22.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@timvaillancourt @arthurschreiber @frouioui