[release-18.0] Add support for MultiEqual opcode for lookup vindexes. (#16975)
#17038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![vitess-bot[bot]](https://avatars.githubusercontent.com/in/213825?s=60&v=4){kind=small}
Signed-off-by: Arthur Schreiber <[email protected]>
vitess-bot
bot
requested review from
frouioui,
GuptaManan100 and
arthurschreiber
as code owners
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
frouioui
approved these changes
Oct 22, 2024
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: Arthur Schreiber <[email protected]>
Comment on lines
+801
to
+820
| "comment": "Disjunction of conjunctions with 4 or more disjunctions", | ||
| "query": "select id from user where (col = 'aa' AND name = 'bb') OR (col = 'cc' AND name = 'dd') OR (col = 'ee' AND name = 'ff') OR (col = 'gg' AND name = 'hh')", | ||
| "plan": { | ||
| "QueryType": "SELECT", | ||
| "Original": "select id from user where (col = 'aa' AND name = 'bb') OR (col = 'cc' AND name = 'dd') OR (col = 'ee' AND name = 'ff') OR (col = 'gg' AND name = 'hh')", | ||
| "Instructions": { | ||
| "OperatorType": "Route", | ||
| "Variant": "Scatter", | ||
| "Keyspace": { | ||
| "Name": "user", | ||
| "Sharded": true | ||
| }, | ||
| "FieldQuery": "select id from `user` where 1 != 1", | ||
| "Query": "select id from `user` where col = 'aa' and `name` = 'bb' or col = 'cc' and `name` = 'dd' or col = 'ee' and `name` = 'ff' or col = 'gg' and `name` = 'hh'", | ||
| "Table": "`user`" | ||
| }, | ||
| "TablesUsed": [ | ||
| "user.user" | ||
| ] | ||
| } |
There was a problem hiding this comment.
These queries generated MultiEqual opcodes on v19 and later, but don't do that on v18. I had to decide on whether to remove these tests or to update them.
I decided to update them with the plans they generate on v18.
Signed-off-by: Arthur Schreiber <[email protected]>
arthurschreiber
force-pushed
the
backport-16975-to-release-18.0
branch
from
a963e9a to
2ad4c68
Compare
|
Because of the query planning differences between v18 and v19, I also had to go and update the executor test cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of #16975