-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Raw MySQL packets when passing results back from VTTablet to VTGate #17080
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Oct 27, 2024
mattlord
added
Component: Query Serving
Type: Performance
and removed
NeedsWebsiteDocsUpdate
What it says
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Oct 27, 2024
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Comment on lines
105
to
109
func (qre *QueryExecutor) shouldConsolidate() bool { | ||
// TODO | ||
if !qre.options.RawMysqlPackets { | ||
return false | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be giving away hot row/shard protection.
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
mattlord
force-pushed
the
raw_mysql_packets
branch
from
October 29, 2024 00:23
d623065
to
80d4ee5
Compare
Signed-off-by: Matt Lord <[email protected]>
mattlord
force-pushed
the
raw_mysql_packets
branch
from
October 29, 2024 00:31
80d4ee5
to
9737e35
Compare
Signed-off-by: Matt Lord <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Query Serving
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
Type: Performance
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the VTgate supports it, this eliminates the costly and unnecessary serialization from the MySQL protocol to protobuf and back again, instead passing the raw MySQL packet in the gRPC message as bytes. This is important as while a query is typically small in bytes, the results are often large and all of this unnecessary copying and allocation cost a lot while providing nothing of value.
Related Issue(s)
Checklist