Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine.Reload(): read InnoDB tables sizes including FULLTEXT index volume #17118

Merged
merged 29 commits into from
Nov 11, 2024

Support for 'legacy' (MySQL 5.7.31 at this time) env for fakesqldb; a…

25949d4
Select commit
Loading
Failed to load commit list.
Merged

engine.Reload(): read InnoDB tables sizes including FULLTEXT index volume #17118

Support for 'legacy' (MySQL 5.7.31 at this time) env for fakesqldb; a…
25949d4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 7, 2024 in 0s

67.44% (+0.28%) compared to 4550640

View this Pull Request on Codecov

67.44% (+0.28%) compared to 4550640

Details

Codecov Report

Attention: Patch coverage is 75.22124% with 28 lines in your changes missing coverage. Please review.

Project coverage is 67.44%. Comparing base (4550640) to head (25949d4).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vttablet/tabletserver/schema/engine.go 76.00% 12 Missing ⚠️
go/mysql/collations/charset/filename.go 73.33% 8 Missing ⚠️
go/mysql/flavor_mysqlgr.go 0.00% 3 Missing ⚠️
go/mysql/flavor_filepos.go 0.00% 2 Missing ⚠️
go/mysql/flavor_mariadb_binlog_playback.go 0.00% 2 Missing ⚠️
go/mysql/flavor_mysql.go 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17118      +/-   ##
==========================================
+ Coverage   67.15%   67.44%   +0.28%     
==========================================
  Files        1571     1570       -1     
  Lines      252250   252285      +35     
==========================================
+ Hits       169409   170148     +739     
+ Misses      82841    82137     -704

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov