Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List join predicates used in GetVExplainKeys #17130

Merged
merged 10 commits into from
Nov 7, 2024

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Nov 1, 2024

Description

This PR enhances GetVExplainKeys to also list the join predicates that were used in the given query. This enable us to achieve vitessio/vt#43 in vt keys and vt benchstat. Example output and usage were detailed in vitessio/vt#43.

Copy link
Contributor

vitess-bot bot commented Nov 1, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 1, 2024
@github-actions github-actions bot added this to the v22.0.0 milestone Nov 1, 2024
@frouioui frouioui added Component: Query Serving Type: Testing and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Nov 1, 2024
systay and others added 3 commits November 4, 2024 10:04
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 71.15385% with 15 lines in your changes missing coverage. Please review.

Project coverage is 67.52%. Comparing base (1a4f2b9) to head (cb8ee86).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vtgate/planbuilder/operators/keys.go 71.15% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17130      +/-   ##
==========================================
+ Coverage   67.44%   67.52%   +0.07%     
==========================================
  Files        1571     1571              
  Lines      252197   252618     +421     
==========================================
+ Hits       170103   170581     +478     
+ Misses      82094    82037      -57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frouioui frouioui merged commit 9946ce8 into main Nov 7, 2024
191 checks passed
@frouioui frouioui deleted the join-predicate-vexplain-keys branch November 7, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants