Add RPC to read the statements to be executed in an unresolved prepared transaction #17131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments to be executed Signed-off-by: Manan Gupta <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
GuptaManan100
added
release notes (needs details)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17131 +/- ##
==========================================
- Coverage 67.43% 67.41% -0.03%
==========================================
Files 1571 1569 -2
Lines 252184 252410 +226
==========================================
+ Hits 170059 170160 +101
- Misses 82125 82250 +125 ☔ View full report in Codecov by Sentry. |
…n-data-rpc Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
…n-data-rpc Signed-off-by: Manan Gupta <[email protected]>
…state of the test Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
requested review from
deepthi,
harshit-gangal,
mattlord,
ajm188,
notfelineit,
rohit-nayak-ps,
shlomi-noach,
systay and
timvaillancourt
as code owners
GuptaManan100
removed
release notes (needs details)
GuptaManan100
added
Type: Enhancement
Comment on lines
-2460
to
2461
| shardTrnxs, err := s.tmc.GetUnresolvedTransactions(newCtx, primary.Tablet) | ||
| shardTrnxs, err := s.tmc.GetUnresolvedTransactions(newCtx, primary.Tablet, req.AbandonAge) | ||
| if err != nil { |
Comment on lines
+2570
to
+2577
| eg, newCtx := errgroup.WithContext(ctx) | ||
| eg.SetLimit(10) | ||
| for _, rm := range transaction.Participants { | ||
| eg.Go(func() error { | ||
| primary, err := s.getPrimaryTablet(newCtx, rm) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
we should collect from all shards irrespective of the error from some shards and return to the caller.
There was a problem hiding this comment.
We might have to do this for other commands as well.
There was a problem hiding this comment.
Let's do that as a follow up. We'll need to add tests for that too.
Signed-off-by: Manan Gupta <[email protected]>
harshit-gangal
approved these changes
Nov 6, 2024
5 tasks
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
systay
approved these changes
Nov 7, 2024
26 tasks
rvrangel
pushed a commit
to rvrangel/vitess
that referenced
this pull request
Nov 21, 2024
…ed transaction (vitessio#17131) Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Renan Rangel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new RPC and vtctldclient command to read a transaction's status if it is still unresolved. This new RPC will also show the commands that were part of the transaction on each of the participating shards that have failures. This is going to be quite useful for users to be able to fix the problem before concluding the transaction.
The next steps are to add the plumbing for vtadmin to also use this new command and show it on the UI when requested. That work will be done in a follow up PR.
Related Issue(s)
Checklist
Deployment Notes