Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VTTablet: Transmit raw MySQL packets for Fields and Rows over wire with grpc buffer #17135

Closed
wants to merge 35 commits into from

cli: do not tweak gogc

a300c8a
Select commit
Loading
Failed to load commit list.
Closed

VTTablet: Transmit raw MySQL packets for Fields and Rows over wire with grpc buffer #17135

cli: do not tweak gogc
a300c8a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 4, 2025 in 1s

67.73% (+0.34%) compared to 216fd70

View this Pull Request on Codecov

67.73% (+0.34%) compared to 216fd70

Details

Codecov Report

Attention: Patch coverage is 36.00917% with 279 lines in your changes missing coverage. Please review.

Project coverage is 67.73%. Comparing base (216fd70) to head (a300c8a).
Report is 90 commits behind head on main.

Files with missing lines Patch % Lines
go/mysql/conn.go 8.73% 115 Missing ⚠️
go/mysql/query.go 23.64% 113 Missing ⚠️
go/mysql/result.go 60.27% 29 Missing ⚠️
go/vt/vttablet/grpctabletconn/conn.go 41.17% 10 Missing ⚠️
go/vt/servenv/grpc_codec.go 78.26% 5 Missing ⚠️
go/vt/vttablet/grpcqueryservice/server.go 16.66% 5 Missing ⚠️
go/vt/vttablet/tabletserver/query_executor.go 90.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17135      +/-   ##
==========================================
+ Coverage   67.39%   67.73%   +0.34%     
==========================================
  Files        1570     1579       +9     
  Lines      252917   258567    +5650     
==========================================
+ Hits       170446   175148    +4702     
- Misses      82471    83419     +948

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov