Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vttablet debugenv changes #17161

Merged
merged 4 commits into from
Nov 28, 2024

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Nov 6, 2024

Description

This PR changes the /debug/env Field names
"PoolSize" -> "ReadPoolSize"
"TxPoolSize" -> "TransactionPoolSize"

It matches the format in which the request is received.
format=json on a POST call to modify the configuration will receive a json response.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Copy link
Contributor

vitess-bot bot commented Nov 6, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 6, 2024
@github-actions github-actions bot added this to the v22.0.0 milestone Nov 6, 2024
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal harshit-gangal force-pushed the vttablet-debugenv-refactor branch from 364927b to 6d27a93 Compare November 25, 2024 15:45
@harshit-gangal harshit-gangal changed the title refactor: Vttablet debugenv refactor vttablet debugenv changes Nov 25, 2024
@harshit-gangal harshit-gangal added Type: Internal Cleanup Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: VTTablet and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Nov 25, 2024
@harshit-gangal harshit-gangal marked this pull request as ready for review November 25, 2024 15:48
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 103 lines in your changes missing coverage. Please review.

Project coverage is 67.39%. Comparing base (0726ea6) to head (af23cee).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vttablet/tabletserver/debugenv.go 0.00% 103 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17161      +/-   ##
==========================================
- Coverage   67.40%   67.39%   -0.02%     
==========================================
  Files        1574     1574              
  Lines      253221   253251      +30     
==========================================
- Hits       170690   170679      -11     
- Misses      82531    82572      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshit-gangal harshit-gangal merged commit a1830b3 into vitessio:main Nov 28, 2024
99 checks passed
@harshit-gangal harshit-gangal deleted the vttablet-debugenv-refactor branch November 28, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VTTablet Type: Enhancement Logical improvement (somewhere between a bug and feature) Type: Internal Cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants