-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vttablet debugenv changes #17161
vttablet debugenv changes #17161
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Harshit Gangal <[email protected]>
…ed, changed pool names Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
364927b
to
6d27a93
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17161 +/- ##
==========================================
- Coverage 67.40% 67.39% -0.02%
==========================================
Files 1574 1574
Lines 253221 253251 +30
==========================================
- Hits 170690 170679 -11
- Misses 82531 82572 +41 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…efactor Signed-off-by: Manan Gupta <[email protected]>
Description
This PR changes the /debug/env Field names
"PoolSize" -> "ReadPoolSize"
"TxPoolSize" -> "TransactionPoolSize"
It matches the format in which the request is received.
format=json
on a POST call to modify the configuration will receive a json response.Related Issue(s)
Checklist
Deployment Notes