Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqltypes: add ToTime conversion funcs #17178

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

derekperkins
Copy link
Member

@derekperkins derekperkins commented Nov 8, 2024

there are already conversions for other native types, but datetime conversions were only available in the vitessdriver. This moves that implementation into sqltypes, so it can be more easily accessed elsewhere. I'm specifically interested in using this with VStream.

The actual implementation was done by @vmg in the driver in 2017, so this just moves it into the sqltypes package, adding a similar ToTime method on Value

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Copy link
Contributor

vitess-bot bot commented Nov 8, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 8, 2024
@github-actions github-actions bot added this to the v22.0.0 milestone Nov 8, 2024
@derekperkins derekperkins added Type: Internal Cleanup Component: General Changes throughout the code base and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Nov 8, 2024
@derekperkins derekperkins force-pushed the sqltype-time-conversion branch from 764608c to a8b20e9 Compare November 8, 2024 07:10
there are already conversions for other native types, but datetime conversions were only available in the vitessdriver. This moves that implementation into sqltypes, so it can be more easily accessed elsewhere.

Signed-off-by: Derek Perkins <[email protected]>
@derekperkins derekperkins force-pushed the sqltype-time-conversion branch from a8b20e9 to fb6115e Compare November 8, 2024 07:16
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 86.04651% with 6 lines in your changes missing coverage. Please review.

Project coverage is 67.31%. Comparing base (f6ca94f) to head (fb6115e).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
go/sqltypes/value.go 85.36% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17178      +/-   ##
==========================================
- Coverage   67.33%   67.31%   -0.03%     
==========================================
  Files        1569     1569              
  Lines      252244   252487     +243     
==========================================
+ Hits       169858   169961     +103     
- Misses      82386    82526     +140     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@vmg vmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why not!

@derekperkins derekperkins merged commit 626b16f into vitessio:main Nov 20, 2024
98 checks passed
@derekperkins derekperkins deleted the sqltype-time-conversion branch November 20, 2024 01:00
rvrangel pushed a commit to rvrangel/vitess that referenced this pull request Nov 21, 2024
Signed-off-by: Derek Perkins <[email protected]>
Signed-off-by: Renan Rangel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: General Changes throughout the code base Type: Internal Cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants