-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: Handle CTEs with columns named in the CTE def #17179
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andres Taylor <[email protected]>
systay
added
Type: Bug
Component: Query Serving
Backport to: release-21.0
Needs to be backport to release-21.0
labels
Nov 8, 2024
systay
requested review from
harshit-gangal,
frouioui,
GuptaManan100 and
arthurschreiber
as code owners
November 8, 2024 08:50
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Nov 8, 2024
systay
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Nov 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17179 +/- ##
==========================================
- Coverage 67.33% 67.33% -0.01%
==========================================
Files 1569 1569
Lines 252476 252476
==========================================
- Hits 170008 170003 -5
- Misses 82468 82473 +5 ☔ View full report in Codecov by Sentry. |
arthurschreiber
approved these changes
Nov 8, 2024
harshit-gangal
approved these changes
Nov 8, 2024
vitess-bot
pushed a commit
that referenced
this pull request
Nov 8, 2024
Signed-off-by: Andres Taylor <[email protected]>
systay
pushed a commit
that referenced
this pull request
Nov 8, 2024
…17179) (#17181) Signed-off-by: Andres Taylor <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
rvrangel
pushed a commit
to rvrangel/vitess
that referenced
this pull request
Nov 21, 2024
Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Renan Rangel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue where the Vitess planner was incorrectly handling recursive Common Table Expressions (CTEs) when column names were defined in the CTE declaration but not in the SELECT clause. Specifically, vtgate was stripping out the column names before passing the query to MySQL, resulting in query failures.
The fix ensures that column names defined in the CTE declaration are preserved, allowing recursive CTE queries to execute correctly in both Vitess and MySQL.
Related Issue(s)
Fixes #17177
Checklist