Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Handle CTEs with columns named in the CTE def #17179

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

systay
Copy link
Collaborator

@systay systay commented Nov 8, 2024

Description

This PR addresses an issue where the Vitess planner was incorrectly handling recursive Common Table Expressions (CTEs) when column names were defined in the CTE declaration but not in the SELECT clause. Specifically, vtgate was stripping out the column names before passing the query to MySQL, resulting in query failures.

The fix ensures that column names defined in the CTE declaration are preserved, allowing recursive CTE queries to execute correctly in both Vitess and MySQL.

Related Issue(s)

Fixes #17177

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Copy link
Contributor

vitess-bot bot commented Nov 8, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 8, 2024
@github-actions github-actions bot added this to the v22.0.0 milestone Nov 8, 2024
@systay systay removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.33%. Comparing base (d9ab9f7) to head (dc0fce9).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17179      +/-   ##
==========================================
- Coverage   67.33%   67.33%   -0.01%     
==========================================
  Files        1569     1569              
  Lines      252476   252476              
==========================================
- Hits       170008   170003       -5     
- Misses      82468    82473       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harshit-gangal harshit-gangal merged commit de16aff into vitessio:main Nov 8, 2024
107 of 111 checks passed
@harshit-gangal harshit-gangal deleted the fix-17177 branch November 8, 2024 12:45
vitess-bot pushed a commit that referenced this pull request Nov 8, 2024
systay pushed a commit that referenced this pull request Nov 8, 2024
…17179) (#17181)

Signed-off-by: Andres Taylor <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
rvrangel pushed a commit to rvrangel/vitess that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Grafana generated recursive CTE fails on v21
3 participants