Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-21.0] Upgrade the Golang version to go1.23.3 #17211

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

frouioui
Copy link
Member

Description

This PR bumps the Golang version to go1.23.3.

Signed-off-by: Florent Poinsard <[email protected]>
Copy link
Contributor

vitess-bot bot commented Nov 11, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 11, 2024
@github-actions github-actions bot added this to the v21.0.1 milestone Nov 11, 2024
@frouioui frouioui added Type: CI/Build Component: General Changes throughout the code base go and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.52%. Comparing base (484f0fb) to head (ae8d708).
Report is 1 commits behind head on release-21.0.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-21.0   #17211      +/-   ##
================================================
+ Coverage         67.49%   67.52%   +0.03%     
================================================
  Files              1570     1570              
  Lines            251375   251375              
================================================
+ Hits             169666   169744      +78     
+ Misses            81709    81631      -78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please correct the PR titles? This is not go 1.23.

@frouioui
Copy link
Member Author

Can you please correct the PR titles? This is not go 1.23.

This is go1.23.3. The downgrade tests are set to go1.22.9 which is done on purpose to match what we use on release-20.0.

@frouioui frouioui merged commit 29f3980 into release-21.0 Nov 11, 2024
198 checks passed
@frouioui frouioui deleted the bump-go-release-21.0 branch November 11, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: General Changes throughout the code base go Type: CI/Build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants