-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for receiving grpc_bind_adress
on vttestserver
#17231
Conversation
Signed-off-by: Gabriel Parreiras <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17231 +/- ##
=======================================
Coverage 67.39% 67.40%
=======================================
Files 1570 1570
Lines 252903 252915 +12
=======================================
+ Hits 170451 170466 +15
+ Misses 82452 82449 -3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
…sio#17231) Signed-off-by: Gabriel Parreiras <[email protected]> Signed-off-by: Renan Rangel <[email protected]>
Description
When
--grpc_bind_address
is supplied tovttestserver
, it is now forwarded up tovtcombo
.Related Issue(s)
Part of #16798
Checklist
Deployment Notes