Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Server.LookupVindexCreate #17242

Merged
merged 17 commits into from
Dec 22, 2024

Update the lookupVindex comment

4e8a539
Select commit
Loading
Failed to load commit list.
Merged

Refactor Server.LookupVindexCreate #17242

Update the lookupVindex comment
4e8a539
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 19, 2024 in 1s

67.60% (+0.07%) compared to 45192d2

View this Pull Request on Codecov

67.60% (+0.07%) compared to 45192d2

Details

Codecov Report

Attention: Patch coverage is 87.50000% with 50 lines in your changes missing coverage. Please review.

Project coverage is 67.60%. Comparing base (45192d2) to head (4e8a539).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vtctl/workflow/lookup_vindex.go 88.28% 45 Missing ⚠️
go/vt/vtctl/workflow/server.go 68.75% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17242      +/-   ##
==========================================
+ Coverage   67.52%   67.60%   +0.07%     
==========================================
  Files        1581     1582       +1     
  Lines      253948   253985      +37     
==========================================
+ Hits       171480   171706     +226     
+ Misses      82468    82279     -189     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.