Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VReplication: recover from closed connection #17249

Merged
merged 2 commits into from
Nov 20, 2024

vreplicator: check connection after error; if connection is closed, r…

4c9eb03
Select commit
Loading
Failed to load commit list.
Merged

VReplication: recover from closed connection #17249

vreplicator: check connection after error; if connection is closed, r…
4c9eb03
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 18, 2024 in 0s

67.39% (+0.00%) compared to 216fd70

View this Pull Request on Codecov

67.39% (+0.00%) compared to 216fd70

Details

Codecov Report

Attention: Patch coverage is 56.25000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 67.39%. Comparing base (216fd70) to head (4c9eb03).

Files with missing lines Patch % Lines
...vttablet/tabletmanager/vreplication/vreplicator.go 70.00% 3 Missing ⚠️
go/vt/binlog/binlogplayer/dbclient.go 0.00% 2 Missing ⚠️
go/vt/binlog/binlogplayer/fake_dbclient.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #17249   +/-   ##
=======================================
  Coverage   67.39%   67.39%           
=======================================
  Files        1570     1570           
  Lines      252917   252930   +13     
=======================================
+ Hits       170446   170470   +24     
+ Misses      82471    82460   -11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov