Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a per-file retry mechanism in the BuiltinBackupEngine #17271

Merged
merged 28 commits into from
Dec 9, 2024

make sure the entire backup ctx is canceled before inspecting the logs

24935b2
Select commit
Loading
Failed to load commit list.
Merged

Implement a per-file retry mechanism in the BuiltinBackupEngine #17271

make sure the entire backup ctx is canceled before inspecting the logs
24935b2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 9, 2024 in 1s

67.50% (+0.09%) compared to 0726ea6

View this Pull Request on Codecov

67.50% (+0.09%) compared to 0726ea6

Details

Codecov Report

Attention: Patch coverage is 68.07760% with 181 lines in your changes missing coverage. Please review.

Project coverage is 67.50%. Comparing base (0726ea6) to head (24935b2).
Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/mysqlctl/s3backupstorage/s3_mock.go 0.00% 121 Missing ⚠️
go/vt/mysqlctl/builtinbackupengine.go 90.20% 24 Missing ⚠️
go/vt/mysqlctl/s3backupstorage/s3.go 53.12% 15 Missing ⚠️
go/vt/mysqlctl/blackbox/utils.go 87.50% 14 Missing ⚠️
go/vt/mysqlctl/errors/errors.go 91.66% 4 Missing ⚠️
go/vt/mysqlctl/cephbackupstorage/ceph.go 0.00% 2 Missing ⚠️
go/vt/mysqlctl/azblobbackupstorage/azblob.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17271      +/-   ##
==========================================
+ Coverage   67.40%   67.50%   +0.09%     
==========================================
  Files        1574     1580       +6     
  Lines      253221   253805     +584     
==========================================
+ Hits       170690   171336     +646     
+ Misses      82531    82469      -62

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov