Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify Ubuntu 24.04 for all jobs #17278

Merged
merged 8 commits into from
Nov 25, 2024

Conversation

dbussink
Copy link
Contributor

This ensures we're on a consistent version and not a floating one where we depend on whenever GitHub upgrades. I believe this was incorrectly done in the past. I had pinned it on 22.04 in the past exactly because of that reason.

Related Issue(s)

This was done incorrectly in #16714 which should have used ubuntu-22.04 and not ubuntu-latest then.

Checklist

I have marked this for backporting because we don't want this to start accidentally failing on older release branches either if this gets upgraded. We should stay consistent here.

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

This ensures we're on a consistent version and not a floating one where
we depend on whenever GitHub upgrades. I believe this was incorrectly
done in the past. I had pinned it on 22.04 in the past exactly because
of that reason.

Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink dbussink added Backport to: release-19.0 Needs to be back ported to release-19.0 Backport to: release-20.0 Needs to be backport to release-20.0 Backport to: release-21.0 Needs to be backport to release-21.0 labels Nov 25, 2024
Copy link
Contributor

vitess-bot bot commented Nov 25, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 25, 2024
@dbussink dbussink added Component: Build/CI Type: CI/Build and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Nov 25, 2024
@github-actions github-actions bot added this to the v22.0.0 milestone Nov 25, 2024
Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.42%. Comparing base (0b51839) to head (909fa63).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17278      +/-   ##
==========================================
+ Coverage   67.37%   67.42%   +0.04%     
==========================================
  Files        1573     1573              
  Lines      253113   253128      +15     
==========================================
+ Hits       170538   170659     +121     
+ Misses      82575    82469     -106     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink dbussink force-pushed the dbussink/specify-ubuntu-24-04 branch 2 times, most recently from aecb454 to f002c89 Compare November 25, 2024 14:19
Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink dbussink force-pushed the dbussink/specify-ubuntu-24-04 branch from f002c89 to 2382ef2 Compare November 25, 2024 14:30
Signed-off-by: Dirkjan Bussink <[email protected]>
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@deepthi deepthi merged commit 145ff6b into vitessio:main Nov 25, 2024
100 checks passed
@deepthi deepthi deleted the dbussink/specify-ubuntu-24-04 branch November 25, 2024 18:03
rohit-nayak-ps pushed a commit that referenced this pull request Nov 26, 2024
Signed-off-by: Dirkjan Bussink <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Dirkjan Bussink <[email protected]>
rohit-nayak-ps pushed a commit that referenced this pull request Nov 26, 2024
Signed-off-by: Dirkjan Bussink <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
rohit-nayak-ps pushed a commit that referenced this pull request Nov 26, 2024
Signed-off-by: Dirkjan Bussink <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport to: release-19.0 Needs to be back ported to release-19.0 Backport to: release-20.0 Needs to be backport to release-20.0 Backport to: release-21.0 Needs to be backport to release-21.0 Component: Build/CI Type: CI/Build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants