-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errant GTID detection fix for VTOrc #17287
Errant GTID detection fix for VTOrc #17287
Conversation
… primary tablet Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17287 +/- ##
==========================================
- Coverage 67.40% 67.40% -0.01%
==========================================
Files 1574 1574
Lines 253205 253209 +4
==========================================
- Hits 170676 170664 -12
- Misses 82529 82545 +16 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good fix.
Description
This PR fixes the issue described in #17286. The problem was fixed by adding a conditional check to see if the tablet we're detecting errant GTIDs on is the primary tablet itself.
Related Issue(s)
Checklist
Deployment Notes