-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve logging in buffering #17294
Merged
Merged
Improve logging in buffering #17294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
requested review from
harshit-gangal,
systay and
frouioui
as code owners
November 28, 2024 11:55
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Nov 28, 2024
GuptaManan100
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Nov 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17294 +/- ##
==========================================
+ Coverage 67.40% 67.64% +0.23%
==========================================
Files 1574 1578 +4
Lines 253221 256333 +3112
==========================================
+ Hits 170690 173400 +2710
- Misses 82531 82933 +402 ☔ View full report in Codecov by Sentry. |
frouioui
approved these changes
Nov 28, 2024
Signed-off-by: Manan Gupta <[email protected]>
systay
approved these changes
Dec 3, 2024
harshit-gangal
approved these changes
Dec 4, 2024
harshit-gangal
force-pushed
the
logs-buffering
branch
from
December 4, 2024 15:27
fa39c67
to
b1f92c6
Compare
harshit-gangal
requested review from
rohit-nayak-ps,
deepthi,
mattlord,
shlomi-noach,
timvaillancourt,
derekperkins,
vmg and
ajm188
as code owners
December 4, 2024 15:27
GuptaManan100
force-pushed
the
logs-buffering
branch
from
December 5, 2024 05:59
b1f92c6
to
fa39c67
Compare
deepthi
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves some logs for buffering to only log when the verbosity level of logging has been increased by the
--v
flag.This will restrict the logs we see from vtgate which has been a problem as far as these logs from buffering are concerned.
Related Issue(s)
Checklist
Deployment Notes