Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support last_insert_id() with argument in SELECT #17295

Closed
wants to merge 11 commits into from

Conversation

systay
Copy link
Collaborator

@systay systay commented Nov 28, 2024

Description

This PR adds support for LAST_INSERT_ID(expr) in Vitess. The feature allows the argument expr to be evaluated and stored as the session’s last insert ID, aligning with MySQL’s behavior. This extends Vitess’ compatibility for queries that rely on setting or retrieving session-level last insert ID values programmatically.

However, unlike MySQL, this feature is limited to usage within SELECT expressions only (i.e., it cannot be used in WHERE, GROUP BY, HAVING, or other non-SELECT contexts), which introduces a remaining compatibility gap.

Related Issue(s)

Work towards fixing #6087

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Copy link
Contributor

vitess-bot bot commented Nov 28, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 28, 2024
@github-actions github-actions bot added this to the v22.0.0 milestone Nov 28, 2024
@systay systay added Type: Feature Component: Query Serving and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 45.28302% with 116 lines in your changes missing coverage. Please review.

Project coverage is 67.45%. Comparing base (ac23e59) to head (31af9e0).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vtgate/engine/save_to_session.go 13.84% 56 Missing ⚠️
go/vt/sqlparser/copy_on_write.go 0.00% 20 Missing ⚠️
...vt/vtgate/planbuilder/operators/save_to_session.go 9.09% 20 Missing ⚠️
.../vt/vtgate/planbuilder/operators/query_planning.go 79.54% 9 Missing ⚠️
...o/vt/vtgate/planbuilder/single_sharded_shortcut.go 72.22% 5 Missing ⚠️
go/vt/vtgate/planbuilder/operator_transformers.go 83.33% 4 Missing ⚠️
go/vt/vtgate/executorcontext/vcursor_impl.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17295      +/-   ##
==========================================
- Coverage   67.46%   67.45%   -0.02%     
==========================================
  Files        1581     1583       +2     
  Lines      253934   254132     +198     
==========================================
+ Hits       171329   171416      +87     
- Misses      82605    82716     +111     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@systay systay changed the title feat: make last_insert_id with argument work for sharded plans Support last_insert_id() with argument Nov 28, 2024
@systay systay marked this pull request as ready for review November 28, 2024 16:44
@systay systay force-pushed the last-insert-id-with-args branch from 8871387 to 2792a28 Compare November 28, 2024 17:01
@harshit-gangal harshit-gangal force-pushed the last-insert-id-with-args branch from 2792a28 to 9bf59d8 Compare December 4, 2024 15:27
@harshit-gangal harshit-gangal force-pushed the last-insert-id-with-args branch from 9bf59d8 to 2792a28 Compare December 4, 2024 16:25
@systay systay marked this pull request as draft December 10, 2024 06:46
@systay systay force-pushed the last-insert-id-with-args branch 2 times, most recently from 6460bfc to 7be85da Compare December 10, 2024 11:13
@systay systay force-pushed the last-insert-id-with-args branch from bb4b1e0 to 0ab3717 Compare December 10, 2024 12:01
@systay systay marked this pull request as ready for review December 10, 2024 12:28
@systay systay changed the title Support last_insert_id() with argument Support last_insert_id() with argument in SELECT Dec 10, 2024
@systay systay force-pushed the last-insert-id-with-args branch 2 times, most recently from b251b81 to ab151c8 Compare December 10, 2024 13:08
@systay systay force-pushed the last-insert-id-with-args branch from ab151c8 to 31af9e0 Compare December 10, 2024 13:26
Comment on lines +64 to +66
### <a id="last_insert_id"/>Added support for LAST_INSERT_ID(expr)

Added support for LAST_INSERT_ID(expr) to align with MySQL behavior, enabling session-level assignment of the last insert ID via query expressions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to link to the PR and/or Issue so there is more context for those wanting to learn more.

Suggested change
### <a id="last_insert_id"/>Added support for LAST_INSERT_ID(expr)
Added support for LAST_INSERT_ID(expr) to align with MySQL behavior, enabling session-level assignment of the last insert ID via query expressions.
### <a id="last_insert_id"/>Added support for LAST_INSERT_ID(expr)
Added support for `LAST_INSERT_ID(expr)` to align with MySQL behavior, enabling session-level assignment of the last insert ID via query expressions. For more information about this change see [#17295](https://github.com/vitessio/vitess/pull/17295).

@@ -0,0 +1,125 @@
/*
Copyright 2019 The Vitess Authors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Copyright 2019 The Vitess Authors.
Copyright 2024 The Vitess Authors.

Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some minor comments, otherwise looks good to me, thank you! 🙇🏻

@systay
Copy link
Collaborator Author

systay commented Dec 17, 2024

Trying to get #17369 to cover all cases. Will close this for now

@systay systay closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants