-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VReplication: Support for filter using IN
operator
#17296
VReplication: Support for filter using IN
operator
#17296
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
bb68809
to
bb7f353
Compare
Signed-off-by: Noble Mittal <[email protected]>
bb7f353
to
e408edd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17296 +/- ##
========================================
Coverage 67.39% 67.40%
========================================
Files 1574 1574
Lines 253209 253325 +116
========================================
+ Hits 170654 170750 +96
- Misses 82555 82575 +20 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Noble Mittal <[email protected]>
Signed-off-by: Noble Mittal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Description
This PR adds support for
IN
filter in VReplication. The PR allowsFilter
to containTuple
values in case ofIN
filter/operator.Related Issue(s)
Checklist
Deployment Notes