-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename DefaultKeyspace() to CurrentKeyspace() #17303
Conversation
Signed-off-by: Andres Taylor <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
@@ -299,12 +299,12 @@ func (vw *VSchemaWrapper) getActualKeyspace() string { | |||
return ks.Name | |||
} | |||
|
|||
func (vw *VSchemaWrapper) DefaultKeyspace() (*vindexes.Keyspace, error) { | |||
func (vw *VSchemaWrapper) CurrentKeyspace() (*vindexes.Keyspace, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we call it current or selected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taking the name from the error
ERROR 1046 (3D000): No database selected
Signed-off-by: Andres Taylor <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17303 +/- ##
==========================================
- Coverage 67.40% 67.39% -0.02%
==========================================
Files 1574 1574
Lines 253221 253277 +56
==========================================
+ Hits 170690 170700 +10
- Misses 82531 82577 +46 ☔ View full report in Codecov by Sentry. |
Description
DefaultKeyspace
is poorly named - it tells us which database the user has selected withuse
or using the connection string.Related Issue(s)
Checklist