-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add missing unit tests in vtctl/workflow
#17304
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Noble Mittal <[email protected]>
d5c2675
to
7d0319c
Compare
ShardNames: []string{"-"}, | ||
} | ||
|
||
env := newTestEnv(t, ctx, defaultCellName, sourceKeyspace, targetKeyspace) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should clean it up:
defer env.close()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
Signed-off-by: Noble Mittal <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17304 +/- ##
==========================================
+ Coverage 67.40% 67.44% +0.03%
==========================================
Files 1574 1576 +2
Lines 253221 253417 +196
==========================================
+ Hits 170690 170914 +224
+ Misses 82531 82503 -28 ☔ View full report in Codecov by Sentry. |
Description
This PR adds missing unit tests for
resharder.go
The code coverage in main:
The code coverage in this branch:
Cmd used:
go test ./go/vt/vttablet/tabletmanager ./go/vt/vtctl/workflow -v -coverpkg=vitess.io/vitess/go/vt/vtctl/workflow... -coverprofile=c.out
Related Issue(s)
Checklist
Deployment Notes