Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: VTGate executor with a runnable context package #17305

Merged
merged 14 commits into from
Dec 4, 2024

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Dec 2, 2024

Description

This PR refactor the VTGate executor to have session and vcursor in executorcontext package so that planbuilder can use the common VCursor implementation in the plan tests.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Copy link
Contributor

vitess-bot bot commented Dec 2, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 2, 2024
@github-actions github-actions bot added this to the v22.0.0 milestone Dec 2, 2024
@harshit-gangal harshit-gangal changed the title Executor context package refactor: Added executor context package Dec 2, 2024
@harshit-gangal harshit-gangal changed the title refactor: Added executor context package refactor: executor context package Dec 2, 2024
@harshit-gangal harshit-gangal changed the title refactor: executor context package refactor: VTGate executor with a runnable context package Dec 2, 2024
systay and others added 2 commits December 2, 2024 13:50
@harshit-gangal harshit-gangal added Type: Internal Cleanup Component: Query Serving and removed NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work labels Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 81.02073% with 119 lines in your changes missing coverage. Please review.

Project coverage is 67.41%. Comparing base (2da3893) to head (696d5e2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vtgate/executorcontext/vcursor_impl.go 75.82% 88 Missing ⚠️
go/vt/vtgate/executorcontext/safe_session.go 70.17% 17 Missing ⚠️
go/vt/vtgate/scatter_conn.go 81.48% 5 Missing ⚠️
go/vt/vtgate/executor.go 95.55% 4 Missing ⚠️
go/test/vschemawrapper/vschema_wrapper.go 89.47% 2 Missing ⚠️
go/vt/vtgate/executorcontext/faketopo.go 91.30% 2 Missing ⚠️
go/vt/vtgate/vtgate.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17305      +/-   ##
==========================================
- Coverage   67.42%   67.41%   -0.02%     
==========================================
  Files        1575     1576       +1     
  Lines      253324   253417      +93     
==========================================
+ Hits       170816   170837      +21     
- Misses      82508    82580      +72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harshit-gangal harshit-gangal added the Benchmark me Add label to PR to run benchmarks label Dec 3, 2024
Copy link
Contributor

vitess-bot bot commented Dec 3, 2024

Hello! 👋

This Pull Request is now handled by arewefastyet. The current HEAD and future commits will be benchmarked.

You can find the performance comparison on the arewefastyet website.

@harshit-gangal harshit-gangal marked this pull request as ready for review December 4, 2024 07:43
safeSession *SafeSession,
marginComments sqlparser.MarginComments,
executor *Executor,
executor iExecute,
Copy link
Collaborator

@systay systay Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! being able to move to an interface here is an important step

Signed-off-by: Andres Taylor <[email protected]>
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nomenclature thing. Totally your call.

@systay systay merged commit ab7b516 into vitessio:main Dec 4, 2024
99 of 100 checks passed
@systay systay deleted the vtgate-refactor branch December 4, 2024 12:50
garfthoffman pushed a commit to github/vitess-gh that referenced this pull request Jan 27, 2025
…7305)

Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Co-authored-by: Andres Taylor <[email protected]>
Signed-off-by: garfthoffman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants