-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for dynamic configuration of DDL settings #17328
Allow for dynamic configuration of DDL settings #17328
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17328 +/- ##
==========================================
+ Coverage 67.39% 67.41% +0.02%
==========================================
Files 1574 1575 +1
Lines 253299 253310 +11
==========================================
+ Hits 170708 170768 +60
+ Misses 82591 82542 -49 ☔ View full report in Codecov by Sentry. |
This allows configuring the vtgate DDL flags dynamically. With this, both online DDL and direct DDL can be disabled and enabled in vtgate without having to restart. Signed-off-by: Dirkjan Bussink <[email protected]>
23d38dd
to
f10a1e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This allows configuring the vtgate DDL flags dynamically. With this, both online DDL and direct DDL can be disabled and enabled in vtgate without having to restart.
Related Issue(s)
Fixes #17327
Checklist