vtorc: fetch all tablets from cells once + filter during refresh

[timvaillancourt]

Description

This PR changes VTOrc tablet discovery to fetch all tablets once and filter them client side

Today, when --clusters_to_watch is set, VTOrc will call refreshTabletsInKeyspaceShard(...) in a goroutine for every shard when refreshing tablets at the interval --topo-information-refresh-duration

Unfortunately calling refreshTabletsInKeyspaceShard(...) is very inefficient because behind the scenes it is just loading all tablets from all cells because fetching just 1-shard or keyspace from the topo store isn't possible without fetching "all" 😱

This means that today a single refresh of all tablets causes shards x # tablets to be read instead of just # tablets, and much of the data read is just duplicated. Instead this PR causes only # of tablets to be fetched each tick

Related Issue(s)

Tracking issue: #17330

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 84 lines in your changes missing coverage. Please review.

Project coverage is 67.69%. Comparing base (ec29bdb) to head (64f2af0).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
go/vt/vtorc/logic/tablet_discovery.go	0.00%	80 Missing ⚠️
go/vt/vtorc/logic/vtorc.go	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #17388      +/-   ##
==========================================
- Coverage   67.71%   67.69%   -0.02%     
==========================================
  Files        1584     1584              
  Lines      254519   254541      +22     
==========================================
- Hits       172338   172316      -22     
- Misses      82181    82225      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[timvaillancourt]

This introduces a problem if shards are added/removed. Moving back to draft

[github-actions]

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

• Push additional commits to the associated branch.
• Remove the stale label.
• Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

[GuptaManan100]

LGTM!