Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup legacy MariaDB bits from vtorc #17415

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Cleanup legacy MariaDB bits from vtorc #17415

merged 1 commit into from
Dec 30, 2024

Conversation

dbussink
Copy link
Contributor

MariaDB is only supported for importing with external tablets and not by letting it be managed with vtorc.

So we can remove the MariaDB bits from vtorc as they are unused and unsupported.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

@dbussink dbussink added Type: Internal Cleanup Component: VTorc Vitess Orchestrator integration labels Dec 19, 2024
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Dec 19, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 19, 2024
@github-actions github-actions bot added this to the v22.0.0 milestone Dec 19, 2024
@dbussink dbussink removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Dec 19, 2024
@dbussink
Cleanup legacy MariaDB bits from vtorc
4f0875d 
MariaDB is only supported for importing with external tablets and not by
letting it be managed with vtorc.

So we can remove the MariaDB bits from vtorc as they are unused and
unsupported.

Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink dbussink force-pushed the cleanup-vtorc-mariadb branch from d52f2cb to 4f0875d Compare December 19, 2024 21:22
@dbussink
Copy link
Contributor Author

@GuptaManan100 Willing to give this a review?

GuptaManan100
GuptaManan100 approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@dbussink dbussink merged commit 76abae4 into vitessio:main Dec 30, 2024
99 checks passed
@dbussink dbussink deleted the cleanup-vtorc-mariadb branch December 30, 2024 10:47
garfthoffman pushed a commit to github/vitess-gh that referenced this pull request Jan 27, 2025
@dbussink @garfthoffman
Cleanup legacy MariaDB bits from vtorc (vitessio#17415)
17f5fc3 
Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: garfthoffman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvaillancourt timvaillancourt timvaillancourt approved these changes

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

Assignees
No one assigned
Labels
Component: VTorc Vitess Orchestrator integration Type: Internal Cleanup
Projects
None yet
Milestone
v22.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dbussink @timvaillancourt @GuptaManan100