Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Views: VTGate changes for seamless integration #17439

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
+131 −30

Merge remote-tracking branch 'upstream/main' into views-vtgate

7d71d6e
Select commit
Loading
Failed to load commit list.
Open

Views: VTGate changes for seamless integration #17439

Merge remote-tracking branch 'upstream/main' into views-vtgate
7d71d6e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 15, 2025 in 0s

67.70% (+0.01%) compared to db4fca3

View this Pull Request on Codecov

67.70% (+0.01%) compared to db4fca3

Details

Codecov Report

Attention: Patch coverage is 71.26437% with 25 lines in your changes missing coverage. Please review.

Project coverage is 67.70%. Comparing base (db4fca3) to head (7d71d6e).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vtgate/vschema_manager.go 23.52% 13 Missing ⚠️
go/vt/vtgate/planbuilder/ddl.go 87.80% 5 Missing ⚠️
go/vt/vtgate/executorcontext/vcursor_impl.go 78.94% 4 Missing ⚠️
go/test/vschemawrapper/vschema_wrapper.go 66.66% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17439      +/-   ##
==========================================
+ Coverage   67.68%   67.70%   +0.01%     
==========================================
  Files        1584     1584              
  Lines      254630   254786     +156     
==========================================
+ Hits       172356   172497     +141     
- Misses      82274    82289      +15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov