Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-20.0] Fix week number for date_format evalengine function (#17432) #17453

Conversation

dbussink
Copy link
Contributor

Backport #17432 to fix CI

Related Issue(s)

Fix from #17432

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

@dbussink dbussink added Type: Bug Backport This is a backport Component: Evalengine changes to the evaluation engine labels Dec 30, 2024
Copy link
Contributor

vitess-bot bot commented Dec 30, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@dbussink dbussink changed the base branch from main to release-19.0 December 30, 2024 11:02
@dbussink dbussink requested a review from vmg as a code owner December 30, 2024 11:02
@dbussink dbussink changed the base branch from release-19.0 to release-20.0 December 30, 2024 11:02
@github-actions github-actions bot added this to the v22.0.0 milestone Dec 30, 2024
@dbussink dbussink force-pushed the release-20.0-backport-evalengine-fix branch from 1feabf5 to 077b072 Compare December 30, 2024 11:03
@dbussink dbussink changed the title Release 20.0 backport evalengine fix [release-20.0] Fix week number for date_format evalengine function (#17432) Dec 30, 2024
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.41%. Comparing base (722cbbd) to head (077b072).
Report is 2 commits behind head on release-20.0.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-20.0   #17453   +/-   ##
=============================================
  Coverage         66.40%   66.41%           
=============================================
  Files              1541     1541           
  Lines            244092   244088    -4     
=============================================
+ Hits             162098   162102    +4     
+ Misses            81994    81986    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbussink dbussink merged commit ffcedfb into vitessio:release-20.0 Dec 30, 2024
95 checks passed
@dbussink dbussink deleted the release-20.0-backport-evalengine-fix branch December 30, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport This is a backport Component: Evalengine changes to the evaluation engine Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants