Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mysql 8.4 docker images #17529

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

L3o-pold
Copy link
Collaborator

@L3o-pold L3o-pold commented Jan 15, 2025

Description

Add MySQL8.4 docker images

Related Issue(s)

Fixes #17519

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Copy link
Contributor

vitess-bot bot commented Jan 15, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 15, 2025
@L3o-pold L3o-pold force-pushed the feature/mysql84-docker-image branch 2 times, most recently from ac13068 to 4a50e03 Compare January 15, 2025 14:07
@L3o-pold L3o-pold changed the title feat: add mysql 8.4 docker image feat: add mysql 8.4 docker images Jan 15, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Jan 15, 2025
@L3o-pold L3o-pold marked this pull request as ready for review January 15, 2025 14:23
@L3o-pold L3o-pold force-pushed the feature/mysql84-docker-image branch from 4a50e03 to 9dd14c1 Compare January 15, 2025 16:42
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.69%. Comparing base (db4fca3) to head (24589d6).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
go/tools/go-upgrade/go-upgrade.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17529   +/-   ##
=======================================
  Coverage   67.68%   67.69%           
=======================================
  Files        1584     1584           
  Lines      254630   254720   +90     
=======================================
+ Hits       172356   172422   +66     
- Misses      82274    82298   +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@L3o-pold L3o-pold force-pushed the feature/mysql84-docker-image branch from 9dd14c1 to 3d9e219 Compare January 15, 2025 17:34
@L3o-pold L3o-pold force-pushed the feature/mysql84-docker-image branch from 3d9e219 to 54712fa Compare January 15, 2025 18:14
@frouioui frouioui added Type: CI/Build Component: Docker and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 15, 2025
@L3o-pold L3o-pold force-pushed the feature/mysql84-docker-image branch 2 times, most recently from 3724e09 to 3e1d7f9 Compare January 16, 2025 08:11
Signed-off-by: Leopold Jacquot <[email protected]>
@L3o-pold L3o-pold force-pushed the feature/mysql84-docker-image branch from 3e1d7f9 to 24589d6 Compare January 16, 2025 08:23
@@ -117,6 +117,33 @@ mysql80)
percona-xtrabackup-80
)
;;
mysql84)
if [ -z "$VERSION" ]; then
VERSION=8.4.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@L3o-pold @frouioui We should use the latest 8.4 release here and not 8.4.0 I think? So 8.4.3?

Copy link
Collaborator Author

@L3o-pold L3o-pold Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8.4.3 requires bookworm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@L3o-pold I think that's a very strong signal we should first upgrade to bookworm then and only add these after that step.

It's moving, but doing it then in that order will make things a lot more easier I think.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can close this and contribute to you other PR if needed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@L3o-pold Let's not do too many things in one PR, we can rebase this one on top of that once it lands? But you can branch off that PR to test more if you want to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: XtraBackup with MySQL 8.4
4 participants