-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add mysql 8.4 docker images #17529
base: main
Are you sure you want to change the base?
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
ac13068
to
4a50e03
Compare
4a50e03
to
9dd14c1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17529 +/- ##
=======================================
Coverage 67.68% 67.69%
=======================================
Files 1584 1584
Lines 254630 254720 +90
=======================================
+ Hits 172356 172422 +66
- Misses 82274 82298 +24 ☔ View full report in Codecov by Sentry. |
9dd14c1
to
3d9e219
Compare
3d9e219
to
54712fa
Compare
3724e09
to
3e1d7f9
Compare
Signed-off-by: Leopold Jacquot <[email protected]>
3e1d7f9
to
24589d6
Compare
@@ -117,6 +117,33 @@ mysql80) | |||
percona-xtrabackup-80 | |||
) | |||
;; | |||
mysql84) | |||
if [ -z "$VERSION" ]; then | |||
VERSION=8.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8.4.3 requires bookworm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@L3o-pold I think that's a very strong signal we should first upgrade to bookworm then and only add these after that step.
It's moving, but doing it then in that order will make things a lot more easier I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can close this and contribute to you other PR if needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@L3o-pold Let's not do too many things in one PR, we can rebase this one on top of that once it lands? But you can branch off that PR to test more if you want to.
Description
Add MySQL8.4 docker images
Related Issue(s)
Fixes #17519
Checklist
Deployment Notes