Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use proper groupId for mysql connector in java #17540

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Use proper groupId for mysql connector in java #17540

merged 2 commits into from
Jan 15, 2025

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Jan 15, 2025 •
edited by deepthi
Loading

Description

This PR fixes an issue introduced by #17522 where the groupID for the new mysql connector was wrong.

Failures can be observed in: https://github.com/vitessio/vitess/actions/runs/12792629637/job/35663543692?pr=17539

In the original PR the Java tests did not run as the paths filtering rule for the Docker Test Cluster 10 workflow do no include ./java/. Since Java is the only thing we test in this workflow, I am renaming it to Java Docker Test to make it more clear.

The old workflow must be marked as unrequired for this PR to be mergeable. Once the PR is merged, we will be able to mark the new workflow as required.

Marking this PR as backport to 21, as the original PR is getting backported there (#17527). I will combine both backport into a single one on #17527

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Jan 15, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 15, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Jan 15, 2025
@frouioui frouioui changed the title Use proper groupId for mysql connector in java Use proper groupId for mysql connector in java Jan 15, 2025
@frouioui frouioui added Type: Bug Component: Java Pull requests that update Java code Backport to: release-21.0 Needs to be backport to release-21.0 and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 15, 2025
@frouioui
Rename workflow
2e590d1 
Signed-off-by: Florent Poinsard <[email protected]>
@frouioui frouioui marked this pull request as ready for review January 15, 2025 17:21
@frouioui frouioui requested a review from dbussink January 15, 2025 17:22
@deepthi deepthi merged commit 8e905aa into vitessio:main Jan 15, 2025
101 checks passed
@deepthi deepthi deleted the fix-java branch January 15, 2025 17:28
@vitess-bot vitess-bot bot mentioned this pull request Jan 15, 2025
Merged
@frouioui frouioui mentioned this pull request Jan 15, 2025
Merged
@mattlord mattlord mentioned this pull request Jan 15, 2025
Open
5 tasks
frouioui added a commit that referenced this pull request Jan 15, 2025
@frouioui
Use proper groupId for mysql connector in java (#17540)
0286d5c 
Signed-off-by: Florent Poinsard <[email protected]>
frouioui added a commit that referenced this pull request Jan 15, 2025
@vitess-bot @frouioui
[release-21.0] Use proper groupId for mysql connector in java (#17540…
c4a4908 
…) (#17541)

Signed-off-by: Florent Poinsard <[email protected]>
Co-authored-by: Florent Poinsard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattlord mattlord mattlord approved these changes

@deepthi deepthi deepthi approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@dbussink dbussink Awaiting requested review from dbussink

Assignees
No one assigned
Labels
Backport to: release-21.0 Needs to be backport to release-21.0 Component: Java Pull requests that update Java code Type: Bug
Projects
None yet
Milestone
v22.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@frouioui @deepthi @mattlord