Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VReplication: Add support for verbosity level in Workflow Show commands #17799

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Changes from self review

6ebd054
Select commit
Loading
Failed to load commit list.
Open

VReplication: Add support for verbosity level in Workflow Show commands #17799

Changes from self review
6ebd054
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 18, 2025 in 1s

67.44% (-0.51%) compared to 70114ad

View this Pull Request on Codecov

67.44% (-0.51%) compared to 70114ad

Details

Codecov Report

Attention: Patch coverage is 73.39450% with 29 lines in your changes missing coverage. Please review.

Project coverage is 67.44%. Comparing base (70114ad) to head (6ebd054).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
go/cmd/vtctldclient/cli/pflag.go 45.45% 12 Missing ⚠️
go/vt/vtctl/workflow/workflows.go 84.05% 11 Missing ⚠️
...d/vtctldclient/command/vreplication/common/show.go 50.00% 2 Missing ⚠️
go/vt/vtadmin/cluster/cluster.go 50.00% 2 Missing ⚠️
.../vtctldclient/command/vreplication/workflow/get.go 0.00% 1 Missing ⚠️
...vtctldclient/command/vreplication/workflow/show.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17799      +/-   ##
==========================================
- Coverage   67.94%   67.44%   -0.51%     
==========================================
  Files        1586     1592       +6     
  Lines      255224   258110    +2886     
==========================================
+ Hits       173420   174079     +659     
- Misses      81804    84031    +2227

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov