Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: preliminary notice about upcoming changes to lifecycle table names #1661

Merged
merged 2 commits into from
Jan 21, 2024

Conversation

shlomi-noach
Copy link
Contributor

This is a v19 preliminary documentation of the new internal table names format, specifically in Table Lifecycle. See story in vitessio/vitess#14582 and changes in vitessio/vitess#14613.

Nothing changes in v19 other than hidden support for new naming.

Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit 25caf0d
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/65acb8f5b515f00008144901
😎 Deploy Preview https://deploy-preview-1661--vitess.netlify.app/docs/19.0/user-guides/schema-changes/table-lifecycle
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shlomi-noach
Copy link
Contributor Author

Copy link
Collaborator

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a couple of minor suggestions.

@@ -80,6 +80,17 @@ Vitess does not track the state of the table lifecycle. The process is stateless
- The table `_vt_EVAC_6ace8bcef73211ea87e9f875a4d24e90_20210918093000` is held until `2021-09-18 09:30:00`
- The table `_vt_DROP_6ace8bcef73211ea87e9f875a4d24e90_20210921170000` is eligible to be dropped on `2021-09-21 17:00:00`

{{< info >}}
Starting Vitess `v20``, the table naming format will change. Tables will be named like so:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra trailing backtick after v20:

Starting in Vitess `v20`, the table naming format will change. Tables will be named like so:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

- `_vt_evc_6ace8bcef73211ea87e9f875a4d24e90_20200915120410_`
- `_vt_drp_6ace8bcef73211ea87e9f875a4d24e90_20200915120410_`

Version `v19` supports the new naming format, but does not generate any tables in this format. Version `v20` will generate tables in the new format, and will support the old format. Support for old format will be dropped in `v21` or later.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to say Version vX as the v in vX is for version. It's fine, but feels a little redundant to me. Personally I would prefer Vitess v19 over Version v19.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Signed-off-by: Shlomi Noach <[email protected]>
@shlomi-noach shlomi-noach merged commit d94f32d into prod Jan 21, 2024
5 checks passed
@shlomi-noach shlomi-noach deleted the preliminary-new-internal-table-names branch January 21, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants