Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Unconfigured heartbeat still serves heartbeat event at throttler requests #1762

Merged
merged 7 commits into from
Jul 8, 2024

Conversation

shlomi-noach
Copy link
Contributor

Documenting the changes in vitessio/vitess#16014.

See also: vitessio/vitess#15303

Copy link

netlify bot commented May 27, 2024

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit f91941d
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/668c0929fa6dd50008c7eed4
😎 Deploy Preview https://deploy-preview-1762--vitess.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shlomi-noach shlomi-noach marked this pull request as draft June 4, 2024 11:42
@shlomi-noach
Copy link
Contributor Author

The code change did not make it into v20. Therefore, the doc changes should go into v21.

@shlomi-noach shlomi-noach marked this pull request as ready for review July 3, 2024 05:38
@shlomi-noach shlomi-noach marked this pull request as draft July 3, 2024 05:39
@shlomi-noach shlomi-noach marked this pull request as ready for review July 3, 2024 05:48
@shlomi-noach
Copy link
Contributor Author

Ready to review. This change also removes sections of the code that relate to EOL versions (v17 and below).

@shlomi-noach shlomi-noach merged commit 2e444be into prod Jul 8, 2024
5 checks passed
@shlomi-noach shlomi-noach deleted the docs-throttler-auto-heartbeats branch July 8, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants