Introduce random JsonPath function
#4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valfirst
requested changes
Mar 1, 2024
README.md
Outdated
| @@ -73,6 +73,9 @@ The function output is dictated by the function itself. | |||
| | `last()` | Provides the last item of an array | Depends on the array | | |||
| | `index(X)` | Provides the item of an array of index: X, if the X is negative, take from backwards | Depends on the array | | |||
| | `distinct()`| Provides an array containing only unique items from the input array | List<E> | | |||
| | `random()` | Provides the random item of an array | Depends on the array | | |||
|
|
|||
| >>>>>>> Stashed changes | |||
There was a problem hiding this comment.
Suggested change
| >>>>>>> Stashed changes |
README.md
Outdated
| @@ -73,6 +73,9 @@ The function output is dictated by the function itself. | |||
| | `last()` | Provides the last item of an array | Depends on the array | | |||
| | `index(X)` | Provides the item of an array of index: X, if the X is negative, take from backwards | Depends on the array | | |||
| | `distinct()`| Provides an array containing only unique items from the input array | List<E> | | |||
| | `random()` | Provides the random item of an array | Depends on the array | | |||
There was a problem hiding this comment.
Suggested change
| | `random()` | Provides the random item of an array | Depends on the array | | |
| | `random()` | Provides one random item from the array | Depends on the array | |
| .collect(Collectors.toList()); | ||
|
|
||
| if (elements.isEmpty()) { | ||
| throw new JsonPathException("Aggregation function attempted random value on empty array"); |
There was a problem hiding this comment.
Suggested change
| throw new JsonPathException("Aggregation function attempted random value on empty array"); | |
| throw new JsonPathException("Aggregation function attempted to get random item from empty array"); |
| throw new JsonPathException("Aggregation function attempted random value on empty array"); | ||
| } | ||
|
|
||
| java.util.Random rand = new java.util.Random(); |
There was a problem hiding this comment.
what is the reason to change it in this particular context? we do not care about security/predictability and just Random works much faster
| java.util.Random rand = new java.util.Random(); | ||
| return elements.get(rand.nextInt(elements.size())); | ||
| } | ||
| throw new JsonPathException("Aggregation function attempted random value using non array"); |
There was a problem hiding this comment.
Suggested change
| throw new JsonPathException("Aggregation function attempted random value using non array"); | |
| throw new JsonPathException("Aggregation function attempted to get random item from not array"); |
uarlouski
force-pushed
the
feature/add-random-feature
branch
2 times, most recently
from
6f8dc4a to
500eaf9
Compare
valfirst
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.