chore: fix clippy warnings

vivienm · Aug 18, 2024 · 0b62b72 · 0b62b72
1 parent 27ceacf
commit 0b62b72
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 14 deletions.
diff --git a/examples/insert_plot.rs b/examples/insert_plot.rs
@@ -1,6 +1,6 @@
 use std::{
     collections::hash_map::RandomState,
-    hash::{BuildHasher, Hash, Hasher},
+    hash::BuildHasher,
     path::{Path, PathBuf},
     time::Duration,
 };
@@ -48,9 +48,9 @@ where
                 .enumerate()
                 .map(|(i, duration)| (i, duration.as_nanos() as f64)),
             0.0,
-            &RED.mix(0.2),
+            RED.mix(0.2),
         )
-        .border_style(&RED),
+        .border_style(RED),
     )?;
 
     Ok(())
@@ -65,9 +65,7 @@ fn main() -> anyhow::Result<()> {
     for i in 1..=args.size {
         // Compute the hash value manually, to avoid the overhead of hashing in the
         // benchmark.
-        let mut hasher = build_hasher.build_hasher();
-        i.hash(&mut hasher);
-        let hash = hasher.finish();
+        let hash = build_hasher.hash_one(i);
 
         let start = std::time::Instant::now();
         bjkst.insert_hash(hash);

diff --git a/src/precision.rs b/src/precision.rs
@@ -304,7 +304,7 @@ impl<'de> serde::Deserialize<'de> for Precision {
         D: serde::Deserializer<'de>,
     {
         let value: u8 = serde::Deserialize::deserialize(deserializer)?;
-        Ok(Precision::try_from(value).map_err(serde::de::Error::custom)?)
+        Precision::try_from(value).map_err(serde::de::Error::custom)
     }
 }
 
@@ -407,18 +407,18 @@ mod tests {
 
     #[test]
     fn new_get() {
-        for precision in Precision::variants().iter().copied() {
-            assert_eq!(precision, Precision::new(precision.get()).unwrap());
+        for precision in Precision::variants().iter() {
+            assert_eq!(*precision, Precision::new(precision.get()).unwrap());
         }
     }
 
     #[test]
     fn variants() {
-        let mut variants: Vec<_> = Precision::variants().iter().copied().collect();
+        let mut variants: Vec<_> = Precision::variants().iter().collect();
         variants.reverse();
         for precision_u8 in Precision::MIN.get()..=Precision::MAX.get() {
             let precision = Precision::new(precision_u8).unwrap();
-            assert!(precision == variants.pop().unwrap());
+            assert!(precision == *variants.pop().unwrap());
         }
         assert!(variants.is_empty());
     }

diff --git a/tests/serde.rs b/tests/serde.rs
@@ -5,9 +5,9 @@ use std::assert_eq;
 use highway::HighwayBuildHasher;
 use uniq_ch::Bjkst;
 
-const SERIALIZED: &'static str = "[4,4,16,0,false,[null,6120665149970903695,null,null,null,null,\
-                                  14520555826795478172,793563473396344097,null,null,null,null,\
-                                  16707926894801950140,null,null,null]]";
+const SERIALIZED: &str = "[4,4,16,0,false,[null,6120665149970903695,null,null,null,null,\
+                           14520555826795478172,793563473396344097,null,null,null,null,\
+                           16707926894801950140,null,null,null]]";
 
 #[test]
 fn serialize() {