Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation for default language selection #4028

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

chenejac
Copy link
Contributor

@chenejac chenejac commented Dec 9, 2024

VIVO GitHub issue: 4026

  • Other Relevant Links (Mailing list discussion, related pull requests, etc.)

What does this pull request do?

Improve documentation about default language.

What's new?

example.runtime.properties, a comment above languages.selectableLocales property has been updated.

How should this be tested?

Read the text in the comment, and check whether it is easy to understand and aligned with the implementation.

Interested parties

Tag (@ mention) interested parties or, if unsure, @VIVO-project/vivo-committers

Reviewers' expertise

Candidates for reviewing this PR should have some of the following expertises:

  1. Natural language knowledge
    1. English

@chenejac chenejac linked an issue Dec 9, 2024 that may be closed by this pull request
Copy link
Member

@hauschke hauschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve documentation for default language selection
2 participants