Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for VIVO-3743 #4029

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Fix for VIVO-3743 #4029

merged 1 commit into from
Dec 12, 2024

Conversation

litvinovg
Copy link
Collaborator

VIVO GitHub issue

What does this pull request do?

Fixes the issue by using POST method in the form to add concepts

How should this be tested?

  • Reproduce the issue
  • Apply the fix
  • Verify that fix fixes the issue

Interested parties

@hauschke @VIVO-project/vivo-committers

Reviewers' expertise

Candidates for reviewing this PR should have some of the following expertises:

  1. Freemarker

Reviewers' report template

General comment

A reviewer should provide here comments and suggestions for requested changes if any.

Testing

A reviewer should briefly describe here how it was tested

Code reviewing

A reviewer should briefly describe here which part was code reviewed

Copy link
Member

@ivanmrsulja ivanmrsulja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reproduced the issue before applying this fix. The fix is resolving the issue.

@chenejac chenejac merged commit da6e4b9 into vivo-project:main Dec 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too long URLs when importing concepts with too many narrower terms from AGROVOC
3 participants