Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply role based search filters in existing endpoints #442

Merged
merged 6 commits into from
Jun 18, 2024

Conversation

litvinovg
Copy link
Member

What does this pull request do?

A follow-up PR for recently merged PR-433 and PR-434
to apply role based search filters in existing endpoints.

What's new?

Applied search filters in IndividualListController, AutocompleteController
Fixed unsafe DataAutoCompleteController, perform authorization checks for each returned result.
Refactored SearchFiltering methods to remove dependency on not needed VitroRequest parameter
Applied search filters to DefaultObjectPropertyFormGeneratory
Removed unused import in DefaultObjectPropertyFormGenerator

How should this be tested?

A description of what steps someone could take to:

Interested parties

@VIVO-project/vivo-committers

@chenejac chenejac self-requested a review February 27, 2024 10:23
chenejac
chenejac previously approved these changes Mar 12, 2024
Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@litvinovg thanks for this PR.

I have posted a couple of comments in the case you have any idea how to additionally improve efficiency of the implementation. Basically, it is about invoking current roles multiple time in some cases. It is the most important that permission set is loaded just one (and it is the case at the moment), therefore I am approving this PR.

@litvinovg litvinovg force-pushed the search_endpoints_hide_data branch from 3cb3103 to eb8cac5 Compare April 23, 2024 06:53
@wwtamu
Copy link

wwtamu commented Jun 17, 2024

@litvinovg
Copy link
Member Author

@chenejac chenejac merged commit c8c4249 into vivo-project:main Jun 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants