[BugFix] Fix Unexpected memory copy (StarRocks#53052)

Signed-off-by: stdpain <[email protected]>
vivo · Nov 21, 2024 · 9aeb07c · 9aeb07c
1 parent bce5d05
commit 9aeb07c
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/be/src/column/column_helper.h b/be/src/column/column_helper.h
@@ -128,8 +128,8 @@ class ColumnHelper {
         if (offset0->size() != offset1->size()) {
             return false;
         }
-        auto data1 = offset0->get_data();
-        auto data2 = offset1->get_data();
+        const auto& data1 = offset0->get_data();
+        const auto& data2 = offset1->get_data();
         return std::equal(data1.begin(), data1.end(), data2.begin());
     }
 

diff --git a/be/src/exec/stream/aggregate/stream_aggregator.cpp b/be/src/exec/stream/aggregate/stream_aggregator.cpp
@@ -233,7 +233,7 @@ Status StreamAggregator::_output_result_changes_with_retract(size_t chunk_size,
     // compute agg count to decide whehter to generate retract info.
     auto agg_count_column = down_cast<const Int64Column*>(
             final_result_chunk->get_column_by_index(_group_by_columns.size() + _count_agg_idx).get());
-    auto agg_count_column_data = agg_count_column->get_data();
+    const auto& agg_count_column_data = agg_count_column->get_data();
 
     // 2. seek previous results from result state table.
     StateTableResult prev_state_result;

diff --git a/be/src/exprs/agg/group_concat.h b/be/src/exprs/agg/group_concat.h
@@ -516,7 +516,7 @@ class GroupConcatAggregateFunctionV2
         // get null info from output columns
         auto output_col_num = ctx->get_num_args() - ctx->get_nulls_first().size() - 1;
         NullColumnPtr nulls = NullColumn::create(chunk_size, false);
-        auto null_data = nulls->get_data();
+        auto& null_data = nulls->get_data();
         for (int j = 0; j < output_col_num; ++j) {
             if (src[j]->only_null()) {
                 for (int i = 0; i < chunk_size; ++i) {

diff --git a/be/src/exprs/array_functions.tpp b/be/src/exprs/array_functions.tpp
@@ -1038,7 +1038,7 @@ private:
         } else {
             bool_array = down_cast<ArrayColumn*>(bool_column.get());
         }
-        auto offsets = bool_array->offsets().get_data();
+        const auto& offsets = bool_array->offsets().get_data();
 
         ColumnViewer<TYPE_BOOLEAN> bool_elements(bool_array->elements_column());
 

diff --git a/be/src/exprs/utility_functions.cpp b/be/src/exprs/utility_functions.cpp
@@ -248,7 +248,7 @@ StatusOr<ColumnPtr> UtilityFunctions::assert_true(FunctionContext* context, cons
             column = FunctionHelper::get_data_column_of_nullable(column);
         }
         auto bool_column = ColumnHelper::cast_to<TYPE_BOOLEAN>(column);
-        auto data = bool_column->get_data();
+        const auto& data = bool_column->get_data();
         for (size_t i = 0; i < size; ++i) {
             if (!data[i]) {
                 throw std::runtime_error(msg);

diff --git a/be/src/storage/column_in_predicate.cpp b/be/src/storage/column_in_predicate.cpp
@@ -392,7 +392,7 @@ class DictionaryCodeInPredicate : public ColumnPredicate {
 
         if (column->has_null()) {
             const NullColumn* null_column = down_cast<const NullableColumn*>(column)->null_column().get();
-            auto null_data = null_column->get_data();
+            const auto& null_data = null_column->get_data();
             for (auto i = from; i < to; i++) {
                 auto index = data[i] >= _bit_mask.size() ? 0 : data[i];
                 filter[i - from] = (!null_data[i]) & _bit_mask[index];