-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use node fs
module instead of execSync
where possible
#60
base: master
Are you sure you want to change the base?
Conversation
Friendly ping on this @vkarpov15. It would be awesome to get it in soon, as I was hoping to start using this library for our local development. |
Oops, closed it accidentally. |
Hi @ThoseGrapefruits is this project still active? |
Not sure, I never got a response on this PR (from 2 years ago now) so I just created a fork of it and rewrote the stuff I wanted to fix or have work differently. I think it works on linux-y distros but it didn’t work on windows for me and probably doesn’t handle ARM builds of mongo, as I recently added that myself. That fork is through my company’s account so I’d have to see if it’s possible to open-source. |
Hi @ThoseGrapefruits thanks for the response, |
Hi @bhumit070, I open-sourced our repo here: https://github.com/Knudge/mango-rs I don't have any time to support it, but it should work ok in most cases. If you encounter a fatal problem, feel free to open an issue on that repo and I will try to find time to look at it, or you can try to tackle it yourself! There's no npm-installable executable as of now, so you'll have to clone the repo and run it from there (instructions are in the README in that repo). Also note that many of the options that |
These were the instances of
execSync
of some system command I found to be pretty easily replaceable with Node'sfs
module methods. Tests seemed to run fine with theexecSync
stub commented out, had to make a couple changes (http
=>https
) to get them working but that seemed to be fixing an existing issue with the tests. It eliminated a lot ofisWin
ternaries, which is nice.The reason I started in on this was that I had an issue running plain
run-rs
on Windows 10, which produced the following error:I tested these changes on Windows 10 (21H1, latest updates) and macOS (Mojave, latest updates).