Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change context of shape translation strings #2249

Merged
merged 3 commits into from
Feb 16, 2025
Merged

Change context of shape translation strings #2249

merged 3 commits into from
Feb 16, 2025

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Feb 16, 2025 •
edited
Loading

Summary:

This PR changes the context name for status label icon shapes from Shapes back to Constants and restores the old translations.

Related Issue(s):

Related #2246

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.6.3 milestone Feb 16, 2025
@vkbo vkbo merged commit c5e0258 into release Feb 16, 2025
9 checks passed
@vkbo vkbo deleted the drop_shape_context branch February 16, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.6.3
Development

Successfully merging this pull request may close these issues.
1 participant
@vkbo