ci: Adding Initial CI #4
vkhitrinAnnotations
1 error and 10 warnings
|
build
Unprocessable Entity: "Pull request review thread path is invalid and Pull request review thread diff hunk can't be blank"
|
|
large size difference between variants:
src/main.rs#L115
warning: large size difference between variants
--> src/app.rs:115:1
|
115 | / pub enum DialogPage {
116 | | RemoveAccount(Account),
| | ---------------------- the second-largest variant contains at least 104 bytes
117 | | RemoveBookmark(Account, Bookmark),
| | --------------------------------- the largest variant contains at least 448 bytes
118 | | }
| |_^ the entire enum is at least 448 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
= note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
|
117 | RemoveBookmark(Account, Box<Bookmark>),
| ~~~~~~~~~~~~~
|
|
useless conversion to the same type: `cosmic::iced_core::Element<'_, app::Message, cosmic::Theme, cosmic::iced::Renderer>`:
src/main.rs#L272
warning: useless conversion to the same type: `cosmic::iced_core::Element<'_, app::Message, cosmic::Theme, cosmic::iced::Renderer>`
--> src/app.rs:272:13
|
272 | (widget::toaster(&self.toasts, widget::horizontal_space(Length::Fill)).into()),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `widget::toaster(&self.toasts, widget::horizontal_space(Length::Fill))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
|
this boolean expression can be simplified:
src/main.rs#L811
warning: this boolean expression can be simplified
--> src/app.rs:811:20
|
811 | if !self.dialog_pages.pop_front().is_some() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.dialog_pages.pop_front().is_none()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
= note: `#[warn(clippy::nonminimal_bool)]` on by default
|
|
this boolean expression can be simplified:
src/main.rs#L817
warning: this boolean expression can be simplified
--> src/app.rs:817:20
|
817 | if !self.dialog_pages.pop_front().is_some() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.dialog_pages.pop_front().is_none()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
|
|
this let-binding has unit value:
src/main.rs#L364
warning: this let-binding has unit value
--> src/app.rs:364:17
|
364 | _ = self.nav.activate(account_page_entity.unwrap());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.nav.activate(account_page_entity.unwrap());`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
|
|
redundant closure:
src/main.rs#L855
warning: redundant closure
--> src/app.rs:855:21
|
855 | |msg| cosmic::app::Message::App(msg),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `cosmic::app::Message::App`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
|
|
unneeded `return` statement:
src/main.rs#L75
warning: unneeded `return` statement
--> src/db/mod.rs:75:9
|
75 | return data;
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
75 - return data;
75 + data
|
|
|
the borrowed expression implements the required traits:
src/main.rs#L88
warning: the borrowed expression implements the required traits
--> src/db/mod.rs:88:19
|
88 | .bind(&account.id)
| ^^^^^^^^^^^ help: change this to: `account.id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
|
the borrowed expression implements the required traits:
src/main.rs#L92
warning: the borrowed expression implements the required traits
--> src/db/mod.rs:92:19
|
92 | .bind(&account.tls)
| ^^^^^^^^^^^^ help: change this to: `account.tls`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/main.rs#L103
warning: the borrowed expression implements the required traits
--> src/db/mod.rs:103:19
|
103 | .bind(&account.tls)
| ^^^^^^^^^^^^ help: change this to: `account.tls`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|