-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lnanderson patch 1 #46
Open
lnanderson
wants to merge
129
commits into
vladpetyuk:master
Choose a base branch
from
PNNL-Comp-Mass-Spec:lnanderson-patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Lnanderson patch 1 #46
lnanderson
wants to merge
129
commits into
vladpetyuk:master
from
PNNL-Comp-Mass-Spec:lnanderson-patch-1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update read_study_design.R
Ms2 to Ms3 linking
fix tool2suffix typo
Upgrade/prune dms tools
…le_imports Bugfix/missing datatable imports
…b_to_matrix Convert crosstab to matrix before constructing MSnSet
…tools Removed DMS functionality from study design tools
…support Added UniProt support to MoTrPAC BIC functions
Greatly reduce computation time and memory. The filter object only requires an MSnID with columns to calculate FDR and columns used for filtering.
Update motrpac_bic_funtions.R
Bugfix: multiple PTM types on same sequence
Fix separation of Specie into protein_id and sequence columns when PTMs are denoted by '@'
Include more robust checks for study design tables
Update how results are written to tables (set na to empty strings) and save RData files with compression
Version change from 0.4.1 to 0.5.0. Update run_plexedpiper and its helper functions to allow for the processing of redox proteomics data. Also increase the minimum MSnID version number to prevent 'function not in namespace' errors caused by installation of the Bioconductor version.
Update test-remap_accessions_refseq_to_gene_fasta to use specific conversion table to ensure reproducibility.
Replace get_study_design_by_dataset_package with read_study_design_from_DMS.
Capitalize MSFragger. Reflow text. Remove ... parameter, which was a carry-over from filter_msgf_data. Align code.
Add input checks. Improve readability with switch. Add global variables.
Fix checks for valid TMT layout.
Remove tidyselect import: the where function is now imported from dplyr.
Replace get_AScore_results with read_AScore_results_from_DMS.
Only run when a new release is published or upon workflow dispatch.
Only keep current release machines.
…r_redox Add redox processing capability to run_plexedpiper
Added Zenodo DOI badge and "Citation Guidance" section to include full citation.
vladpetyuk
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add updated Zenodo DOI badge and "Citation Guidance" to include full citation.