Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make EmbeddedAssetReader public for external use along with its preloaded and load_path_sync functions #16

Merged
merged 2 commits into from
Feb 18, 2024

Conversation

zachbateman
Copy link
Contributor

In my specific project, I am using the preloaded and load_path_sync functions to load assets outside of the normal Bevy usage (avoiding Handles and ensuring the data is available for use). This PR makes a few internal pieces public so those features can still be used with Bevy 0.12.

Just sharing a change I am using-please include this or not as you see fit, @mockersf.

@zachbateman zachbateman mentioned this pull request Nov 13, 2023
@mockersf
Copy link
Member

I removed the pub during the update to Bevy 0.12 because I didn't remember why they were and I didn't want to write docs for them 😄

No issue for me making them pub, could you write some doc for them and fix clippy? I can merge it and fix it after otherwise.

@zachbateman
Copy link
Contributor Author

I think that should handle what we need, but please let me know if you'd like further tweaks on my end.

@mockersf mockersf merged commit c5fc4da into vleue:main Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants