Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burrowing Heaven #1160

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Kitsunemitsu
Copy link
Contributor

About The Pull Request

Adds the burrowing heaven, with a few minor changes.

  1. It moves around. This lets you corner it in certain places, or catch it just as it's about to hit a body.
  2. Requires 2 people to look at it, opposite of Schadenfreude.

Why It's Good For The Game

Changelog

🆑
add: Added Burrowing HEaven
/:cl:

@Kitsunemitsu Kitsunemitsu added the Abnormality This is the abnormality label Jul 21, 2023
@Kitsunemitsu Kitsunemitsu marked this pull request as ready for review July 25, 2023 11:34
abnormality_origin = ABNORMALITY_ORIGIN_LOBOTOMY

//Sight Check
/mob/living/simple_animal/hostile/abnormality/burrowingheaven/Life()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming you used code from the animated wizard statues, so is there a reason you added the sight check to Life() rather than calling a proc when needed? This applies to Schaden code too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Schad it's used for movement, was also used for movement on BH too.

//Need 2 people to actually work on it
/mob/living/simple_animal/hostile/abnormality/burrowingheaven/ChanceWorktickOverride(mob/living/carbon/human/user, work_chance, init_work_chance, work_type)
if(!seen) //If you're only considered "seen" because the other living player(s) are all on another Z level, disregard it during work specifically.
to_chat(user, "<span class='warning'>You are injured by [src]!</span>") // Keeping it clear that the bad work is from being seen and not just luck.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use some flavor text to make it more obvious Burrowing's gimmick is active.


..() //To do; Unique animation.
if(!solo_punish)
SLEEP_CHECK_DEATH(5 SECONDS)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would calling changeNext_move(time) work to delay Burrowing actions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tried that, will do.

name = "burrowing heaven"
desc = "As it spreads its wings for an old god, a heaven just for you burrows its way."
icon_state = "heaven"
armor = list(RED_DAMAGE = 30, WHITE_DAMAGE = 40, BLACK_DAMAGE = 40, PALE_DAMAGE = 30) // 140
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

holy shit WAW magic bullet

Comment on lines +15 to +16
melee_damage_lower = 99
melee_damage_upper = 97
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

th... these are backwards???

abno_info = list(
"Work with The Burrowing Heaven must proceed while the Containment Unit is viewable by more than two people.",
"Commencing work while in the view of only one person will cause The Burrowing Heaven's counter to decrease.",
"The burrowing Heaven became completely stationary when it was viewed by two or more people. Please take this into account when suppressing it.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"The burrowing Heaven became completely stationary when it was viewed by two or more people. Please take this into account when suppressing it.")
"The Burrowing Heaven became completely stationary when it was viewed by two or more people. Please take this into account when suppressing it.")

@LanceSmites328
Copy link
Contributor

Doesn't this just walk around right now and hit people instead of teleporting and doing room based damage?

@Kitsunemitsu Kitsunemitsu force-pushed the Burrowing-heaven branch 2 times, most recently from 2679977 to 4d2fb50 Compare April 15, 2024 11:09
@Kitsunemitsu Kitsunemitsu force-pushed the Burrowing-heaven branch 2 times, most recently from 5861098 to 357acb5 Compare January 13, 2025 04:51
initial commit

Apply suggestions from code review

Update waw.dm

Update waw.dm

records

changes heaven

Update burrowing_heaven.dm

Update burrowing_heaven.dm

records

burrowing heaven EGO

Update burrowing_heaven.dm

Update burrowing_heaven.dm

Co-Authored-By: [̸R̵e̵d̴a̴c̶t̸e̸d̴]̵ <[email protected]>
This reverts commit 2f1c962.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Abnormality This is the abnormality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants