Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY] Adds Reloading to pretty much all guns #2017

Merged
merged 9 commits into from
Jun 6, 2024

Conversation

Kitsunemitsu
Copy link
Contributor

About The Pull Request

Adds reloading to all guns.

Quick overview of what I did in specific:
All semi guns have a doubled fire rate
Specific guns that already fired fast, had their damage doubled.
All automatic guns were given a high mag cap and fast reload speed.

Crossbows, Boys and magic staves were not changed.

Why It's Good For The Game

Could make gunplay more interesting. Who the fuck knows.
Players also voted for this like 42 to 4
image

Changelog

🆑
balance: All guns now reload.
/:cl:

@Kitsunemitsu Kitsunemitsu added Do Not Merge Do not merge, untill a headcoder approves it. Test Merge Candidate Should be test merged to test its functionality. Feature Something new being added. labels Mar 31, 2024
@Kitsunemitsu Kitsunemitsu force-pushed the gun-ammo branch 2 times, most recently from d3234bb to 48145ad Compare April 12, 2024 03:03
asd

Update ego_gun.dm

Update ego_gun.dm

update

Update lobotomy-corp13.dme
Copy link
Contributor

@tile4 tile4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I think this is how I approve the thing I pointed out? But looks good from what I see as I don't see any more possible mistakes.

@Kitsunemitsu Kitsunemitsu removed Do Not Merge Do not merge, untill a headcoder approves it. Test Merge Candidate Should be test merged to test its functionality. labels May 10, 2024
@Kitsunemitsu Kitsunemitsu changed the title [NEEDS TM] Adds Reloading to pretty much all guns [READY] Adds Reloading to pretty much all guns May 10, 2024
@Anonmare
Copy link
Contributor

Mostly good, just issue with Tough pistols (can't be reloaded) and some guns with weird magazine capacity (ex. Song of the Past has less capacity than its mini-version)

Copy link
Contributor

@LanceSmites328 LanceSmites328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, I would like that other change but it's comparably small and shouldn't hold this PR back any longer.

@LanceSmites328 LanceSmites328 merged commit 1a7ad3f into vlggms:master Jun 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Something new being added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants