Critical Hits #2131
Open
Critical Hits #2131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update he.dm adds critical hits Update item_attack.dm
Kitsunemitsu
force-pushed
the
critical-hits
branch
from
99335d5 to
6e3abc0
Compare
This reverts commit 6e3abc0.
LanceSmites328
requested changes
Aug 6, 2024
Comment on lines
+141
to
+149
| for(var/mob/living/L in range(1, user)) | ||
| var/aoe = force | ||
| var/userjust = (get_modified_attribute_level(user, JUSTICE_ATTRIBUTE)) | ||
| var/justicemod = 1 + userjust/100 | ||
| aoe*=force_multiplier | ||
| aoe*=justicemod | ||
| if(L == user || ishuman(L)) | ||
| continue | ||
| L.apply_damage(aoe, RED_DAMAGE, null, L.run_armor_check(null, BLACK_DAMAGE), spread_damage = TRUE) |
There was a problem hiding this comment.
Damage here should be calculated outside of the loop (We aren't expecting nor really caring if the user's stats change somehow in the middle of this instantaneous attack). This could also thereby utilize HitInTurf to prevent crits from hitting allies seemingly randomly.
|
Will be pushed into the funny #2669 pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Adds a new Critical hit mechanic, separate from Poise.
You get 0.02% crit chance for every prudence you have
On Crit, get a bonus damage that scales with fortitude.
Adds in the ability for crit multiplier weapons and weapons that give a big bonus on crit.
Why It's Good For The Game
No fucking Clue.
We'll figure that out later.
Changelog
🆑
add: Added Critical Hits
/:cl: