Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the runtime of civilians spawning with a tier 0 skill book + optimizations and cleanup #2606

Merged
merged 7 commits into from
Dec 16, 2024

Conversation

Gboster-0
Copy link
Collaborator

About The Pull Request

  • Reworks a good chunk of code surrounding civilians skill books spawning in, making the game no longer try to spawn non-existant books
  • Brings fishing skills up to the coding standard for skills

Why It's Good For The Game

Reworks a good chunk of code surrounding civilians skill books spawning in, making the game no longer try to spawn non-existant books

  • Made a good chunk of non-map runtimes on COL/CF rounds. Using a static var we can now also generate the list once and never again, saving a lil bit of processing at the cost of memory.

Brings fishing skills up to the coding standard for skills

  • "Give me 300 of this, 18000 of that" <-- statements made by the utterly deranged

Changelog

🆑
code: Fixed runtimes relating to civilians spawning in with level 0 skill books
/:cl:

@Gboster-0 Gboster-0 added Code improvement Code is now easier to copy paste. Fix There was a bug, and we fixed it! labels Dec 9, 2024
Copy link
Collaborator

@InsightfulParasite InsightfulParasite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good in my book. Approved!

Copy link
Contributor

@Kitsunemitsu Kitsunemitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleans up fishskill code, and generally important updates

@Kitsunemitsu Kitsunemitsu merged commit 1b70b58 into vlggms:master Dec 16, 2024
8 checks passed
@Gboster-0 Gboster-0 deleted the better-skill-tiers branch December 16, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code improvement Code is now easier to copy paste. Fix There was a bug, and we fixed it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants