Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes initialize hints on a lot of objects, optimizes effects, city structures load immediatelly upon mapload, Fixes some cases where template_noop should be used #2608

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Gboster-0
Copy link
Collaborator

@Gboster-0 Gboster-0 commented Dec 13, 2024

About The Pull Request

  • Moves a bunch of code for random rooms into ModularTegustation
  • FIxes a lot of initialize hints not being returned
  • Effects are now optimized by their init() and del() being overriden (this is a TG change)
  • Fixes some wrongly placed walls/areas that should be template_noop in backstreets templates
  • Makes structures be instantly loaded at round-start
  • Changes the city timelock to 5 minutes from 15 minutes

Why It's Good For The Game

Moves a bunch of code for random rooms into ModularTegustation

  • Modular code my beloved

FIxes a lot of initialize hints not being returned

  • Bug fix gud

Effects are now optimized by their init() and del() being overriden (this is a TG change)

  • We use a lot of those, we have them be optimized

Fixes some wrongly placed walls/areas that should be template_noop in backstreets templates

  • template noop should be placed where we really dont care what exists, since it just ignores those areas and lets us not uselessly delete and recreate the same stuff

Makes structures be instantly loaded at round-start

  • As much as possible should be loaded at round-start so players do not lag as much during runtime, i do not know why we were not already doing that

Changes the city timelock to 5 minutes from 15 minutes

  • Since backstreets now load at round-start, we can afford to bump this down (it will still exists purelly because its funny)

Changelog

🆑
balance: The backstreets is now immediatelly loaded, and unlocks at 5 minutes from 15 minutes
/:cl:

@Gboster-0 Gboster-0 added Balance Improvements towards balance of the game. Code improvement Code is now easier to copy paste. Fix There was a bug, and we fixed it! Side content This PR affects side modes. labels Dec 13, 2024
@Gboster-0 Gboster-0 changed the title Fixes initialize hints on a lot of objects, optimizes effects, changes the city backstreets timelock from 15 to 5 minutes, structures load immediatelly Fixes initialize hints on a lot of objects, optimizes effects, city structures load immediatelly upon mapload, Fixes some cases where template_noop should be used Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Improvements towards balance of the game. Code improvement Code is now easier to copy paste. Fix There was a bug, and we fixed it! Side content This PR affects side modes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants